-
Notifications
You must be signed in to change notification settings - Fork 798
[Benchmarks] Update benchmarks README.md #18954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add information on --filter
and --preset
. I would say that these are as commonly used parameters as the ones already mentioned in this readme.
are stored [here](https://oneapi-src.github.io/unified-runtime/performance/). | ||
|
||
## Output formats | ||
### Output formats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the extra #
intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think this fits into the subsection of “Results”.
devops/scripts/benchmarks/README.md
Outdated
## Contribution | ||
|
||
The requirements and instructions above are for building the project from source | ||
without any modifications. To make modifications to the specification, please see the | ||
[Contribution Guide](https://oneapi-src.github.io/unified-runtime/core/CONTRIB.html) | ||
for more detailed instructions on the correct setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the UR CONTRIB actually relevant for benchmark scripts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can be dropped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should remove the entire Contribution section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the section could be removed as there is a CONTRIB.md
file in the same directory with a description of contributing to benchmarks framework. Contributions to Unified Runtime are irrelevant to the benchmarks framework
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to leave this section because it finishes the README nicely. I've updated the link to the benchmarks CONTRIB.
@intel/llvm-gatekeepers, please merge |
Can you please provide |
Sorry. Accidentally pressed all the wrong buttons. |
Preview: https://github.com/wlemkows/llvm/tree/readme-update/devops/scripts/benchmarks